refactor!: move container options to shared containers key
#387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agitter
reviewed
Sep 5, 2025
Collaborator
agitter
left a comment
agitter
left a comment
There was a problem hiding this comment.
The contributing guide will also need updates.
Documentation build overview
Show files changed (6 files in total): 📝 6 modified | ➕ 0 added | ➖ 0 deleted
|
1 task
Collaborator
Author
|
3cadfc4 was the only change necessary in |
tristan-f-r
added
the
P-medium
Collaborator
Author
|
This has been tagged with |
agitter
approved these changes
Oct 24, 2025
Collaborator
agitter
left a comment
agitter
left a comment
There was a problem hiding this comment.
It looks like previous review comments were addressed.
The hash_level usage is still unintuitive to me, but I trust it will make more sense once I see the future changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #297. [See #297 for extra motivation of the
containerskey beyond the diamond dependency reason below]This is 1/2 PRs being extracted from #329 to make it easier to add testing to
dsub. The second PR is #390. (See the note after the horizontal break)[See the diff without whitespace changes from config indentation]
I've avoided splitting this PR up before since the extra file is motivated by #329: specifically, we move
ContainerSettingstocontainer_schema.pyinstead of keeping it inschema.pyto prevent the future dependency diamond of:containers.pydepends on the schema for getting extra container settings (the follow-up PR above is going to refinecontainers.py's dependency on the schema by specifically only making it depend oncontainer_schema.py)[algorithm].py, because ofrun_containers, depends oncontainers.pyschema.pywill, thanks to feat!: typed PRA#run #329, depend on[algorithm].pyfor all algorithms.I want to be able to pass a more rich suite of options to
run_container_dsub(specifically,local, to specify thatdsubshould be mocked withdockeras specified indsub's documentation), which causes a strangedsub_localparameter to be propagated up all the way torun_container. Instead of adding this parameter or making an auxiliary object to pass both parameters in, it seemed better to reuse the object we were reading out of the global config anyway (we do this all overcontainers.pyanyway for container parameters, so it might be better overall to pass them in as a parameter).